Is S.Africa more expensive than Thailand for holiday things such as cabs, eating out, pubbing/clubbing etc?

Have found good hotel/apartment deals in both countries, and good airfare deals too (about €450 return from Dublin to Jo'burg!...amazing) I've never been to either place though so unaware of costs?! Thanks

Yes, I would say SA is more expensive than Thailand although flight and accommodation would be your biggest expense by far, also consider car hire costs (essential if you want to travel in SA but not in Thailand). Cabs are pricey. Eating/drinking is generally very good value compared to Europe. Thailand probably has a much wider price/quality range than SA but of course you get what you pay for...

As a South African I find Thailand MUCH cheaper and MUCH safer.